Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MinioAdminClient using HTTP client #1291

Merged
merged 27 commits into from
Nov 1, 2023
Merged

Refactor MinioAdminClient using HTTP client #1291

merged 27 commits into from
Nov 1, 2023

Conversation

pbrw
Copy link
Contributor

@pbrw pbrw commented Jul 25, 2023

Attempt to solve these issues #829 #1243

  • Implemented encryption/decryption of sensitive payload which is the hard part about using the HTTP Admin API
  • Refactored code to reuse the request authentication functionality
  • Implemented basic user management methods (user_add, user_remove, user_info, list_users)
  • Wrote some tests

Now it should be straightforward to implement the rest of MinIO Admin API

balamurugana
balamurugana requested changes Jul 25, 2023
View reviewed changes
minio/__init__.py Outdated Show resolved Hide resolved
minio/crypto.py Show resolved Hide resolved
minio/minioadminhttp.py Outdated Show resolved Hide resolved
minio/http.py Outdated Show resolved Hide resolved
minio/helpers.py Outdated Show resolved Hide resolved
minio/error.py Outdated Show resolved Hide resolved
minio/error.py Outdated Show resolved Hide resolved
minio/datatypes.py Outdated Show resolved Hide resolved
minio/api.py Outdated Show resolved Hide resolved
@Nox-404 Nox-404 mentioned this pull request Aug 14, 2023
Closed
@pbrw pbrw force-pushed the minio-admin-http branch from 57b065b to 06bbb39 Compare August 21, 2023 12:00
@pbrw
Copy link
Contributor Author

pbrw commented Aug 21, 2023 •
edited
Loading

I rewrote it according to your requests. At the moment I commented all the MinioAdmin commands with mc and I will rewrite them with HTTP in subsequent commits

@pbrw pbrw force-pushed the minio-admin-http branch from 29865ff to af17fbc Compare August 21, 2023 16:34
@pbrw pbrw force-pushed the minio-admin-http branch from af17fbc to e2b3c90 Compare August 21, 2023 16:37
@balamurugana
Copy link
Member

I rewrote it according to your requests. At the moment I commented all the MinioAdmin commands with mc and I will rewrite them with HTTP in subsequent commits

@pbrw I sent a PR pbrw#1 to your fork instead of lengthy review. Please review and merge it in your fork.

@balamurugana
Copy link
Member

@pbrw I sent you PR pbrw#3 and reverted prometheus_create() addition. Few APIs are removed and site replication APIs are added. I also increased minor version to indicate backward compatibility.

harshavardhana
harshavardhana requested changes Sep 26, 2023
View reviewed changes
minio/minioadmin.py Outdated Show resolved Hide resolved
@balamurugana balamurugana changed the title MinIO Admin user management using HTTP Refactor MinioAdminClient using HTTP client Sep 27, 2023
@balamurugana
Copy link
Member

@pbrw Please fix CI failure

pbrw
pbrw commented Sep 27, 2023
View reviewed changes
minio/minioadmin.py Outdated Show resolved Hide resolved
minio/minioadmin.py Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit c37956b into minio:master Nov 1, 2023
15 checks passed
@balamurugana balamurugana mentioned this pull request Nov 5, 2023
Closed
@jessebot
Copy link
Contributor

how do you specify credentials now? Previously MinioAdmin took an alias.

@jessebot jessebot mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbrw @balamurugana @jessebot @harshavardhana